constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
386 stars 58 forks source link

Data Access View - double notifications and GDELT runtime exception - when plugin is run with no options selected #1840

Closed GammaVel closed 1 year ago

GammaVel commented 1 year ago

Prerequisites

Description

For some of the Data Access View plugins, an error message is being displayed along with the runtime error message. Previously, this was happening for more of the plugins however this was fixed under #1641. The ones that still have this issue require changes to the constellation-adaptors repo.

Steps to Reproduce

  1. Download the latest nightly build for testing this
  2. Open a new graph and go to the Data Access view
  3. Select the following plugins to run and click Go (don't fill in the required info to get them to run successfully)

Extend

Enrich

GDELT plugins are displaying an exception but no error message, it would be good to fix these too: image

Expected behaviour: Single error message

Actual behaviour: Runtime error + error message, or Runtime error (GDELT)

Reproduces how often:100%

Additional Information

NA

GammaVel commented 1 year ago

Thank you @OrionsGuardian for looking into this issue and fixing it. I tried this out again and I am no longer getting both the runtime error and the error message, I am only getting the error message which is a great improvement. All of the file options were looking good on the DAV, here is one example of where it was working.

image