Prerequisites

[x] Reviewed the checklist
[ ] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Removed the code that deactivated the changes the colour, hide and size visualisation buttons made when the Analytic View closes. As the Analytic View now keeps its state for each graph, the deactivation code is not necessarily required anymore. If the Conversation View or Layers View was open when the Analytic View was closed and there were at least 2 graphs open, the deactivating of those changes would cause Constellation to become completely unresponsive.

Alternate Designs

An attempt was made to have the changes made deactivate whenever the graph stopped being active and then reactivate when it became active again. This could potentially be considered after the next release.

Why Should This Be In Core?

Fixes major bug in Core.

Benefits

Possible Drawbacks

Verification Process

Open the Analytic View, Conversation View and two graphs Close the Analytic View Observe that Constellation does not become unresponsive

constellation-app / constellation

Remove Deactivate on Close in Analytic View #2154