sonarcloud[bot]
commented
1 month ago 
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code
Prerequisites
[ ] Reviewed the checklist
[ ] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Addressing the issue found in #2157
Changed some key areas of code that were using the global fixed threadpool to instead have their own dedicated fixed threadpool. This avoids situations where functionality was being unnecessarily blocked when the global fixed threadpool was exhausted.
Alternate Designs
Considered using the cached threadpool, but for long running processes, it is recommended to use a fixed threadpool.
Why Should This Be In Core?
Prevent unnecessary locks/blocking in the system.
Benefits
Improve system performance and usability.
Verification Process
Create multiple new graphs and confirm you can keep creating new graphs beyond the number of logical processors in your system. And each new graph is fully functional (ie. can be edited)
Applicable Issues
2157