constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
386 stars 58 forks source link

Fix github testing issues #2167

Closed Quasar985 closed 3 months ago

Quasar985 commented 3 months ago

Prerequisites

Description of the Change

Fixed test files that would fail randomly and inconsistently. The two main causes were a concurrency problem in QueryPhasePane and its tests, and similar issues in ValueInputPane when binding a property in a run later.

Alternate Designs

N/A

Why Should This Be In Core?

N/A

Benefits

Unit tests are far less likely to fail

Possible Drawbacks

Verification Process

To validate the ValueInputPane still functions as intended:

  1. Open data access view
  2. Check "Test Parameters"
  3. Click the down drop (recent values list) next to"Test1" parameter and observe no recent values
  4. Type a value into "Test1" parameter
  5. Click "GO"
  6. Click the down drop (recent values list) next to"Test1" parameter
  7. Observe the previous string entered is in the down drop

Can only really verify tests by re-running the tests on this PR and observing they don't fail. In my experience the tests were more likely to randomly fail on GitHub, rather than locally.

Applicable Issues

N/A

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud