[x] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Fixed test files that would fail randomly and inconsistently. The two main causes were a concurrency problem in QueryPhasePane and its tests, and similar issues in ValueInputPane when binding a property in a run later.
Alternate Designs
N/A
Why Should This Be In Core?
N/A
Benefits
Unit tests are far less likely to fail
Possible Drawbacks
Verification Process
To validate the ValueInputPane still functions as intended:
Open data access view
Check "Test Parameters"
Click the down drop (recent values list) next to"Test1" parameter and observe no recent values
Type a value into "Test1" parameter
Click "GO"
Click the down drop (recent values list) next to"Test1" parameter
Observe the previous string entered is in the down drop
Can only really verify tests by re-running the tests on this PR and observing they don't fail. In my experience the tests were more likely to randomly fail on GitHub, rather than locally.
Prerequisites
[x] Reviewed the checklist
[x] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Fixed test files that would fail randomly and inconsistently. The two main causes were a concurrency problem in QueryPhasePane and its tests, and similar issues in ValueInputPane when binding a property in a run later.
Alternate Designs
N/A
Why Should This Be In Core?
N/A
Benefits
Unit tests are far less likely to fail
Possible Drawbacks
Verification Process
To validate the ValueInputPane still functions as intended:
Can only really verify tests by re-running the tests on this PR and observing they don't fail. In my experience the tests were more likely to randomly fail on GitHub, rather than locally.
Applicable Issues
N/A