constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
385 stars 59 forks source link

Fix the conversation view to not show conversations from other graphs. #2169

Closed Auriga2 closed 1 month ago

Auriga2 commented 1 month ago

Prerequisites

Description of the Change

Conversation view no longer shows conversations from the last viewed graph when the current graph does not contain conversation data of its own.

Alternate Designs

Why Should This Be In Core?

Bug fix

Benefits

Bug fix

Possible Drawbacks

Verification Process

  1. Open a graph with conversation data
  2. Create a new graph and add 2 nodes and a transaction, which would not have conversation data to display
  3. Open Conversation View and verify conversations are shown when the first graph is selected
  4. Verify conversations clear when the nodes are selected on the second graph

Applicable Issues

https://github.com/constellation-app/constellation/issues/2149

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint