constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
385 stars 59 forks source link

Welcome page allows multiple copies of the same graph to open, throwing exceptions #2172

Open Auriga2 opened 1 month ago

Auriga2 commented 1 month ago

Prerequisites

Description

Recent graphs in the Welcome page can be clicked multiple times, which opens the same graph in multiple tabs.

image

If you do this on a larger graph, constellation can run out of memory and stuck.

image

Clicking on these graphs/tabs while partially loading throws this exception.

image

Steps to Reproduce

  1. Open constellation, open a larger graph and close the app which will add it in the Recent section in the Welcome page.

  2. Open constellation and double click on the graph above in the Welcome page

  3. Observe it creating 2 graphs.

  4. Clicking on the graph above in the Welcome page multiple times can cause the 1st exception

  5. Clicking on the graph above in the Welcome page a few times and clicking on these graphs/tabs that are partially loading can cause the 1st exception

Expected behaviour: Welcome page not allowing to open multiples of the same graph and no exceptions thrown

Actual behaviour: Welcome page allows to open multiples of the same graph and exceptions are thrown

Reproduces how often: 90% with a larger graph

Additional Information

Observed in v3.0.0.-rc1 Same behavior in v2.11