constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
386 stars 58 forks source link

Testable Graph Builder exception fix #2178

Closed Auriga2 closed 2 months ago

Auriga2 commented 2 months ago

Prerequisites

Description of the Change

The exception was throwing if Experimental ->Developer ->Testable Graph Builder was clicked while there's a non empty graph open in constellation. Fixed it by opening the Testable Graph in a new analytic graph rather than just showing a warning message.

Alternate Designs

Could have just shown a warning message, but opening it in a new graph with the same click make it even easier for developers.

Why Should This Be In Core?

Fix exception

Benefits

Open Testable graph with one click

Possible Drawbacks

Verification Process

Select Experimental ->Developer ->Testable Graph Builder without opening any graphs and with any open graphs

Applicable Issues

https://github.com/constellation-app/constellation/issues/2150

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud