Open Delphinus8821 opened 1 month ago
Failed conditions
4.8% Coverage on New Code (required ≥ 80%)
Can still get multiple copies of the same graph opened. When you first start Constellation, the first graph you try to open takes some time before it opens. During that time if you keep clicking on the Recent Files entry on the Welcome Page it will queue up more instances to open the same file.
I think the only way to stop this from occurring would be to only allow one graph to be opened from the Recent Graphs at a time. So you wouldn't be able to open multiple different graphs at the same time which I think could be more annoying
Prerequisites
[x] Reviewed the checklist
[ ] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
The Welcome View currently allows you to open the graphs stored in the Recent Graphs as many times as you want and this can sometimes cause exceptions. This change stops users from clicking the graph in Recent Graphs multiple times and having the graph open multiple times, instead it will swap to the tab with the already open graph.
This change still allows for multiple graphs of the same name to be opened as they would have to be saved in different locations.
Alternate Designs
Why Should This Be In Core?
Bugfix to stop an exception from occurring in Core.
Benefits
Possible Drawbacks
Verification Process