constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
385 stars 59 forks source link

Update NotifyDisplayer to popup on same screen #2193

Closed andromeda-224 closed 2 weeks ago

andromeda-224 commented 3 weeks ago

Prerequisites

Description of the Change

Alternate Designs

Why Should This Be In Core?

Benefits

To display Alerts on the same screen as the app.

Possible Drawbacks

Verification Process

  1. Create a new Graph.

  2. Select menu item Experimental -> Developer -> Test Notifications All notifications/dialogs should be displayed on the same screen as the app.

  3. Move the app to another screen and select menu item Experimental -> Developer -> Test Notifications. All notifications/dialogs should be displayed on the same screen as the app.

  4. Have just one graph open.

  5. Select menu item Tools -> Compare Graph The warning dialog should appear on the same screen as the app Move the app to another screen and repeat the steps. The warning dialog should appear on the same screen as the app

  6. Select menu item File -> Import-> From File...

  7. Click the "+" to add a file

  8. In File Name textbox, enter a non-existent file eg. abcdefg

  9. Click open

  10. The warning dialog of "Invalid file(s) found" should appear on the same screen as the app. Move the app to another screen and repeat the steps. The warning dialog should appear on the same screen as the app

Applicable Issues

2159

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
47.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud