constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
386 stars 58 forks source link

Occasional java.lang.IllegalArgumentException when savings graphs #2195

Open Auriga2 opened 2 months ago

Auriga2 commented 2 months ago

Prerequisites

Description

Occasionally java.lang.IllegalArgumentException is thrown when saving graphs, probably too fast. I could only recreate consistently when running constellation under development. But saw the same error in v3.0.0-rc2 after opening the same graphs edited in dev.

image

Steps to Reproduce

  1. Open Constellation in Dev and open 4 saved graphs

  2. Edit all graphs to mark them as changed. You can zoom or use find view as below. Open find view and search for a simple string like "ac" in Basic Find view. Select All Open graphs and click Find All, which marks all graphs as changed.

  3. Close other graphs except the Active graph, quickly, clicking Save at the prompt. If no exceptions are thrown, open the same set of graphs and repeat from step 2 again.

Expected behaviour: No exception when saving graphs too quickly

Actual behaviour: Exception when saving too quickly

Reproduces how often: 90%

Additional Information

Observed while testing https://github.com/constellation-app/constellation/issues/2118, so verified the behavior present prior to those changes.