constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
385 stars 59 forks source link

Update FileChooser.java to popup confirmation dialog on same screen #2196

Closed andromeda-224 closed 2 weeks ago

andromeda-224 commented 2 weeks ago

Prerequisites

Description of the Change

Set the main window to be the parent of the FileChooser approver so that the confirmation dialog will pop up on the same screen/monitor.

Alternate Designs

Why Should This Be In Core?

This will enable the FileChooser confirmation dialog to appear on the same screen as the app.

Benefits

This will enable the FileChooser confirmation dialog to appear on the same screen as the app.

Possible Drawbacks

Verification Process

The first 2 set of steps (File Save and File Open) are to verify that the first 2 issues raised in ticket #2082 have already been fixed.

1 - File Save a) Open a graph b) Export the graph to an SVG c) export the graph to a KML d) Save the KML in the same location as the exported SVG e) Note no warning dialog

2 - File Open a) Open the Data Access View b) Navigate to the Test Parameters Plugin c) Select Open File parameter d) Select a text file. e) Note no warning dialog.

This next set of steps are to verify that the confirmation dialog appears on the same screen as the app (the third issue raised in the ticket).

3 - File confirmation dialog a) Move the Consty app to a different screen that is not the primary monitor. b) Open a graph. c) Export the graph to an SVG. Note the name. d) Once the file is saved, export the graph to the same SVG file name. e) The confirmation dialog is on the same screen as the app.

Applicable Issues

2082

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud