constellation-app / constellation

A graph-focused data visualisation and interactive analysis application.
https://constellation-app.com
Apache License 2.0
386 stars 58 forks source link

Fix the search all graphs on find view to traverse correctly #2198

Closed Auriga2 closed 2 months ago

Auriga2 commented 2 months ago

Prerequisites

Description of the Change

When searching All Graphs, the lists of results were resetting comparing the number of graphs open to the number of graphs with search results. Hence when there were graphs without matching results, the results lists were not resetting correctly, causing the Find All, Find Next and Find Previous buttons to appear stuck on certain graphs.

Due to the same reason, the changes to existing graphs didn't reflect in the search results. E.g. If you delete a single node with a matching search criteria, it was still traversing when search buttons were pressed.

Removed the ResetStatePlugin which wasn't working consistently and added the resetting functionality in the FindViewController. Now the search results are updated promptly as the graphs are changed and closed.

Find All button is now traversed similar to the Find next button, not the Find previous button. (That direction changes time to time, maybe something to fix?)

Alternate Designs

Using ResetStatePlugin didn't work consistently, because sometimes the graph was already closed by the time the Plugin was run.

Why Should This Be In Core?

Bug fix

Benefits

Better UX

Possible Drawbacks

Verification Process

Applicable Issues

https://github.com/constellation-app/constellation/issues/2118

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
53.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud