Fix recent graphs screenshots not being accurate

Quasar985 commented 2 weeks ago

Prerequisites

[x] Reviewed the checklist
[x] Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait for the "CI / Unit Tests") to complete first. Failed Unit tests can be debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Fixed bug that would cause the screenshots for recent graphs to all be the same if "save all" was used. Now, if this happens, each graph that is saved has the correct screenshot for the "recent graphs" sections.

Alternate Designs

N/A

Why Should This Be In Core?

N/A

Benefits

Screenshots for recent graphs are now accurate, minimizing confusion.

Possible Drawbacks

None.

Verification Process

Open Consty
Open a few existing graphs, or create multiple new graphs.
Modify all of them, then click File -> Save All
Close Consty
Re-Open Consty
Look at Welcome Page
The graphs that were saved should appear in the recent graphs section, and observe their preview screenshots are accurate to each graph

Applicable Issues

https://github.com/constellation-app/constellation/issues/2125

mimosa2 commented 1 week ago

I have tested with 5 graphs (edited and saved) and opening Consty the first time all appeared correctly on the welcome page. I then opened 2 graphs from the welcome page and edited again and saved. Re-opening Consty displayed one of the edited graph correctly but the second one displayed as a black square. The screenshot saved as black square although the edited graph opened correctly.

Quasar985 commented 1 week ago

I have tested with 5 graphs (edited and saved) and opening Consty the first time all appeared correctly on the welcome page. I then opened 2 graphs from the welcome page and edited again and saved. Re-opening Consty displayed one of the edited graph correctly but the second one displayed as a black square. The screenshot saved as black square although the edited graph opened correctly.

I'll take a look. The black square happens when the screenshot is taken before the graph was rendered on screen, so it sounds like a timing issue I've got to fix.