search

constellation-mc / blame-log

Prepending method callers since 2023
MIT License
2 stars 0 forks source link

[Quilt] Crash on startup #1

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

MC 1.19.2 BlameLog 0.1.1

Trying to use the mod with Quilt results in a crash on startup. Let me know if this needs to be reported to Quilt, instead.

Logs: https://gist.github.com/SplendidAlakey/4528cd840bcda130da3fb38f09138dd2

melontini commented 1 year ago

Thanks for the report!

I'm not sure how quilt works internally, so my judgement is questionable, but it might be related to class loading. (Patching JDK classes gives a similar error, they just don't see classes outside of bootstrap)

You can try reporting it to quilt, but I don't think they'll do anything about it, since this mod is begging to break something. (Instrumentation, very early entrypoints, etc.)

melontini commented 1 year ago

Well, good news!

 [main/INFO]: [me.melontini.crackerutil.danger.instrumentation.InstrumentationAccess#bootstrap] Successfully attached instrumentation agent.
 [main/INFO]: [BlameLog] Trying to hack Loggers with Instrumentation
 [main/WARN]: [BlameLog] Quilt support is extremely hacky. Be ware!
 [main/WARN]: [BlameLog] Opening java.lang to UNKNOWN to make defineClass accessible
 [main/INFO]: [java.lang.Class#forName0] [BlameLog] Hacking Loggers was successful, as you can see... Wait, I'm not "java.lang.Class#forName0" >:|
 [main/INFO]: [java.lang.Class#forName0] [BlameLog] Hacked 192 methods
 [main/WARN]: [org.spongepowered.asm.mixin.transformer.MixinConfig#onSelect] Reference map 'blame-log-refmap.json' for #blame-log:blame-log.mixins.json could not be read. If this is a development environment you can ignore this message
SplendidAlakey commented 1 year ago

Just tried it out as well, seems to be working fine. Should I close the issues or keep it open, since you consider this experimental?

melontini commented 1 year ago

Yeah, you should close them.