search

construct-framework / construct5

Construct5 is the HTML5 version of the Construct Template Development Framework for the Joomla! CMS. Construct5 is now solely focused on Joomla 2.5.
http://construct-framework.com/
12 stars 3 forks source link

Modified column-group gutter + cols padding, shaved off 40% of file size #10

Closed CristinaSolana closed 12 years ago

CristinaSolana commented 12 years ago
betweenbrain commented 12 years ago

Awesome, thanks!

Just curious about your thinking regarding changing the column widths. Was it just to give them a bit more space between the content in them?

CristinaSolana commented 12 years ago

Yes sir, that was it. Also to remove padding from the left of the first column and right of the last. :) On May 9, 2012 6:51 AM, "Matt Thomas" < reply@reply.github.com> wrote:

Awesome, thanks!

Just curious about your thinking regarding changing the column widths. Was it just to give them a bit more space between the content in them?

Reply to this email directly or view it on GitHub: https://github.com/betweenbrain/construct5-pro/pull/10#issuecomment-5597252

betweenbrain commented 12 years ago

Cool. I normally do that with the gutter classes so that the column widths don't need to me messed with. Usually so IE doesn't bork on it's bad math. This works too ;)

CristinaSolana commented 12 years ago

Those columns already had padding attached to them, not sure if that was like that or if I made that change 6 months ago, but I can change it so that the passing or margin is added by .gutter. On May 9, 2012 7:00 AM, "Matt Thomas" < reply@reply.github.com> wrote:

Cool. I normally do that with the gutter classes so that the column widths don't need to me messed with. Usually so IE doesn't bork on it's bad math. This works too ;)

Reply to this email directly or view it on GitHub: https://github.com/betweenbrain/construct5-pro/pull/10#issuecomment-5597371

betweenbrain commented 12 years ago

It's not a big deal. The only reason I might want to change it, to use the original widths, is for consistency with the other grids. You can see how I approached that at https://github.com/construct-framework/construct5/blob/master/css/grids/construct.css#L168.

I'm totally open to suggestions for a better approach too.

betweenbrain commented 12 years ago

I added a quick gist to https://gist.github.com/2648292 so you can see what I was thinking earlier