Missed major preprocessor variable define if minor version is not equal zero, like 5.1

consulo / consulo-unity3d

Frameworks: Unity3D

Apache License 2.0

103 stars 10 forks source link

Missed major preprocessor variable define if minor version is not equal zero, like 5.1 #28

Closed ernestp closed 9 years ago

ernestp commented 9 years ago

After project import one of project dependencies not found: DarkTonic.CoreGameKit Code for this module included in sources. Tried to rebuild - doesn't help.

Consulo: 1.0 #966 JVM: 1.8.0_40 Unity: 5.1.2f Mac OS X: 10.10.4 Unity plugin: 1449

Seems that problem is that Consulo not define UNITY_5 for compile. That brakes compilation logic for that module. Seems that this problem was not appears in older version of Unity plugin.

VISTALL commented 9 years ago

Preprocessor - is known issue of C# plugin, currenly is not fixed

https://github.com/consulo/consulo-csharp/issues/118

ernestp commented 9 years ago

Seems that variable UNITY_5_1 is defined. But in Unity 5.1.2 code compiles fine. So seems that both variables UNITY_X and UNITY_X_X must be defined.

VISTALL commented 9 years ago

Oh - that bug, i will change title of this issue