search

consumet / consumet.ts

Nodejs library that provides high-level APIs for obtaining information on various entertainment media such as books, movies, comic books, anime, manga, and so on.
https://consumet.org/extensions/list/
GNU General Public License v3.0
413 stars 226 forks source link

Fixed gogoanime info endpoint #484

Closed hasilon88 closed 7 months ago

hasilon88 commented 7 months ago

Bugfix

Tested and everything works except getting the episodes but that isn't available on the gogoanime website as well

Summary

I am self hosting a API that uses this library and everything was fine until suddenly, the info endpoint kept returning a empty object. I looked around and modified the code a bit until I finally saw a error message that said that the website related to the SSL certificate isn't correct and it gave me a list of URLs that were. I replaced the old ajax #URL by the new recommended one and it starting working again.

The only issue still left is that the list of episodes is still empty but that is a issue directly from gogoanime. The reason I know this is because if you go on their website, you will see that the episodes lists never load so I believe once they fix that issue, the list of episode should work here as well.

2 users posted a issue about the exact same bug that this fixes:

  1. First bug post related to the info endpoint from goganime
  2. Second bug post related to the info endpoint from gogoanime

I am sorry if this is not very clear, this is my first contribution ever. If you want to ask me anything, please don't hesitate.

hasilon88 commented 7 months ago

Can someone explain to me what failed and what's the error please. I don't understand it.

hase0278 commented 7 months ago

Can someone explain to me what failed and what's the error please. I don't understand it.

You only changed js file? Not ts one?

hasilon88 commented 7 months ago

yeah, since the ts file only contains signatures, i didn't need to modify the ts file

dhelbegor commented 7 months ago

Consumet were created using typescript. That file that u just modified is a builded file that was created by running npm run build. U need to modify the .ts one. And the .js files should not be versioned.

hasilon88 commented 7 months ago

Which related ts file should i modify because the ones i see are all interfaces (method signatures)

dhelbegor commented 7 months ago

I think that this is what u are looking for.

https://github.com/consumet/consumet.ts/blob/master/src%2Fproviders%2Fanime%2Fgogoanime.ts#L27

hasilon88 commented 7 months ago

Oh thank you, I couldn't find it earlier, I'll try changing that instead.

kurays015 commented 7 months ago

Suddenly, the meta/anilist endpoint is not working and the episodes is also empty.

dhelbegor commented 7 months ago

Oh thank you, I couldn't find it earlier, I'll try changing that instead.

Yw mate :D