jhollist commented 4 years ago

Noticed that lagosne_select and create_lagos_extent.R were both still referencing version 1.087.1. This was the default behavior in lagosne_select and causes an error if the dt is not explicitly used. I updated both of these references from 1.087.1 to use lagosne_version() instead.

Also bumped version, added some documentation in lagosne_select, and updated CITATION.

Thanks again for a great package. Got a paper in review now that uses LAGOSNE (and that is how I noticed this issue). Hope to have it out in 4-6 months or so.

codecov-commenter commented 4 years ago

Codecov Report

Merging #113 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #113   +/-   ##
======================================
  Coverage    9.86%   9.86%           
======================================
  Files          12      12           
  Lines         608     608           
======================================
  Hits           60      60           
  Misses        548     548

Impacted Files	Coverage Δ
R/select.R	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7236da...eb4650a. Read the comment docs.

jsta commented 4 years ago

Looks great. Thanks! Looking forward to your paper.

cont-limno / LAGOSNE

Replaced references to legacy versions of LAGOSNE #113

Codecov Report