search

cont-limno / LAGOSNE

Interface to the LAke multi-scaled GeOSpatial & temporal database :earth_americas:
https://cont-limno.github.io/LAGOSNE/
15 stars 8 forks source link

column names for buffer metadata tables imported incorrectly #34

Closed limnoliver closed 7 years ago

limnoliver commented 7 years ago

In tables lakes4ha_buffer100m and lakes4ha_buffer500m, column is "lagoslakeid" after importing through package, but column name in geo v1.040 is "lakes4ha_buffer100m_lagoslakeid" and "lakes4ha_buffer100m_lagoslakeid".

jsta commented 7 years ago

Do you have code that depends on them being in long form (lakes4ha_buffer100m_lagoslakeid)? I seem to remember specifically changing them to be in short form (lagoslakeid). I guess I'm unclear on why we have a long form in the first place...

limnoliver commented 7 years ago

Yeah, I don't like long form either. I was writing the help files for the different tables, and for each table with lagoslakeid, it is sometimes imported with the scale in front (iws), and sometimes not (buffers). So I guess if you're manually changing them at some point, I would prefer the shortened version "lagoslakeid".

The issue came up because I reported it as an inconsistency in the LAGOS export. Is this the only column name that gets manipulated on import?

jsta commented 7 years ago

Looks like I manipulated lakes4ha.buffer100m* and lakes4ha.buffer500m*

https://github.com/cont-limno/LAGOS/blob/master/R/ingest.R#L130-L155

I hope I didn't miss any.

limnoliver commented 7 years ago

You just missed all of the iws tables, which also have iws_lagoslakeid variables.

limnoliver commented 7 years ago

Looks like the next LAGOS export will remove all prefixes from "lagoslakeid", so this will be a non-issue soon.

jsta commented 7 years ago

I still see prefixes in the latest export. Its just that they are buffer100m_lagoslakeid instead of lakes4ha_buffer100m_lagoslakeid.