search

contain-rs / bit-set

A Set of Bits
Apache License 2.0
63 stars 25 forks source link

Add serde support #27

Closed LizzyFleckenstein03 closed 2 months ago

Gankra commented 1 year ago

serde2..? huh..? (oh I see, trying to make "serde" the interface for flipping this on, and not "serde-impl" or whatever)

Gankra commented 1 year ago

This implementation seems incorrect. A BitSet is equivalent to a BTreeSet<usize>, the thing you serialize/deserialize should be the indices that contain a "1" in the BitVec (which is e.g. what the iterator yields).

pczarn commented 2 months ago

This needs some rework.