search

contain-rs / bit-set

A Set of Bits
Apache License 2.0
63 stars 25 forks source link

Migrate to `edition = "2021"` #45

Open pczarn opened 2 months ago

waywardmonkeys commented 2 months ago

I was going to do this but noticed that these crates advertise (but don't validate) that they support a very old MSRV.

What should the MSRV policy be fore this and bit-vec?

pczarn commented 2 months ago

Oh right!! as a compromise I would recommend migrating to 2018 and wait a couple years to bump further to 2021. Serde requires us (optionally) having 2018 anyway!

I remember some crate having a cool MSRV/SemVer policy, but forgot what it was...

By the way, validation of MSRV is implemented here and you may copy it: https://github.com/pczarn/gearley/blob/master/.github/workflows/ci.yml#L61-L75

pczarn commented 2 months ago

Well, the most important question is: how important is MSRV and how much care should I dedicate to making the policy careful?

pczarn commented 1 month ago

@waywardmonkeys Would you still like to do this for set and vec? An expert said Min. Supported Rust Version does not matter that much, because tooling/rustup makes it very easy to update rustc and the entire toolchain.

pczarn commented 1 month ago

We should support rustc 1.68.

waywardmonkeys commented 1 month ago

I will do it.

pczarn commented 1 month ago

Thanks.