Closed SpaceManiac closed 4 years ago
Any chance of a release with this fix? The crate is still fairly widely used, and with https://github.com/rust-lang/rust/pull/71274 we are turning the UB here into a panic, which breaks the released version of this crate.
Done.
@Gankra looks like something went wrong? I cannot see a new version at https://crates.io/crates/linked-hash-map.
whoops sorry, fixed
Awesome, thanks. :)
@Gankra is there any plan on yanking the older (unsound) versions? This crate has many reverse dependencies yanking the older ones would ensure that they obtain a sound version of this crate instead of bumping the minimum dependency to 0.5.3
@Gankra a friendly reminder - it'd be great to yank the previous version as I've been bitten by this as well when using the toml_edit crate and had to scan the backtrace and dig a bit to find that I should bump this transitive dependency to 0.5.3.
Pretty please :bow: (if not that's fine too ofc, just let us know :slightly_smiling_face:)
FWIW, cargo audit
should also tell you that this update is necessary.
Scary-looking warning fixable as far as I can tell with one-line patch