search

contain-rs / linked-hash-map

A HashMap wrapper that holds key-value pairs in insertion order
https://contain-rs.github.io/linked-hash-map/linked_hash_map/
Apache License 2.0
169 stars 60 forks source link

Update to Serde 0.9. #73

Closed jimmycuadra closed 7 years ago

jimmycuadra commented 7 years ago

Serde 0.9 was recently released and required a few changes to update.

FlashCat commented 7 years ago

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

jimmycuadra commented 7 years ago

Clippy doesn't seem to have been updated for the latest nightly Rust, but my changes should be okay without clippy passing.

dtolnay commented 7 years ago

r? @apasel422

apasel422 commented 7 years ago

This looks fine to me, but Travis is still failing on nightly. Some other problem with clippy?

dtolnay commented 7 years ago

Clippy has not been updated to the most recent nightly yet. You can follow along here: https://github.com/Manishearth/rust-clippy/pull/1505. It is not related to this PR.

jimmycuadra commented 7 years ago

Thanks for merging! Would someone release a new version to crates.io, please?

apasel422 commented 7 years ago

Published on crates.io as 0.4.0.