contain-rs / linked-hash-map

A HashMap wrapper that holds key-value pairs in insertion order
https://contain-rs.github.io/linked-hash-map/linked_hash_map/
Apache License 2.0
169 stars 60 forks source link

Remove PartialEq::ne implementation #74

Closed dtolnay closed 7 years ago

dtolnay commented 7 years ago

The build is currently failing with this error:

error: re-implementing `PartialEq::ne` is unnecessary
   --> src/lib.rs:686:5
    |
686 |       fn ne(&self, other: &Self) -> bool {
    |  _____^ starting here...
687 | |         self.len() != other.len() || self.iter().ne(other)
688 | |     }
    | |_____^ ...ending here
    |
note: lint level defined here
   --> src/lib.rs:35:38
    |
35  | #![cfg_attr(feature = "clippy", deny(clippy))]
    |                                      ^^^^^^
    = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#partialeq_ne_impl
apasel422 commented 7 years ago

I'd accept a PR.

apasel422 commented 7 years ago

Fixed by #73.