search

contain-rs / lru-cache

A cache that holds a limited number of key-value pairs
https://contain-rs.github.io/lru-cache/lru_cache/
Apache License 2.0
82 stars 36 forks source link

Build with nightly and slightly update APIs #15

Closed zonyitoo closed 9 years ago

FlashCat commented 9 years ago

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @Gankro (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

apasel422 commented 9 years ago

Can you also squash the last three commits and rebase the entire thing on master (to get Travis working)? Thanks!

zonyitoo commented 9 years ago

Sure. Let me do this.

Gankra commented 9 years ago

Thanks a bunch!!!

:confetti_ball: