search

contain-rs / lru-cache

A cache that holds a limited number of key-value pairs
https://contain-rs.github.io/lru-cache/lru_cache/
Apache License 2.0
83 stars 36 forks source link

Update linked-hash-map to the new 0.1.0 version #27

Closed jstnlef closed 8 years ago

jstnlef commented 8 years ago

When playing with this I noticed that the code was downloading and compiling an old version of linked-hash-map. I ran the unit tests with the new version and everything appeared to be all right.

FlashCat commented 8 years ago

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @reem (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

reem commented 8 years ago

Thanks!