search

contain-rs / lru-cache

A cache that holds a limited number of key-value pairs
https://contain-rs.github.io/lru-cache/lru_cache/
Apache License 2.0
83 stars 36 forks source link

Implement `at_max_capacity` #30

Closed jstnlef closed 7 years ago

jstnlef commented 8 years ago

Issue: https://github.com/contain-rs/lru-cache/issues/9

I think it makes more sense to have either not initialize the underlying map or initialize the map at max capacity. Let me know what you think. I also updated the various references to the cache capacity to max_size as not to confuse capacity as allocated space with capacity as number of elements in the cache.

FlashCat commented 8 years ago

r? @reem

(I've picked a reviewer for you, use r? to override)

FlashCat commented 8 years ago

:umbrella: The latest upstream changes (presumably #31) made this pull request unmergeable. Please resolve the merge conflicts.

jstnlef commented 8 years ago

I forgot to mention that I rebased this awhile ago.

jstnlef commented 7 years ago

Wanted to check up on this. Is anything more needed?

Gankra commented 7 years ago

Hey sorry about missing this, we're totally strapped for maintainer resources, and are entering maintenance mode. We are no longer accepting novel APIs.