Some changes to work better without mutability

contain-rs / lru-cache

A cache that holds a limited number of key-value pairs

https://contain-rs.github.io/lru-cache/lru_cache/

Apache License 2.0

82 stars 36 forks source link

Some changes to work better without mutability #41

Closed luser closed 7 years ago

luser commented 7 years ago

I built something atop my changes in https://github.com/contain-rs/lru-cache/pull/40 and I wound up needing a pair of small additional changes:

First, I needed a get method that returned a non-mutable reference, since my changes in that PR make get_mut available only when using the default Count metric, so when using a different metric there's no way to actually get items from the cache. This differs from the immutable get PR in that it still updates the LRU state of the cache, it just returns a non-mutable reference to the cache entry.
Second, I wanted to use contains_key without having a mutable reference to the cache, which is pretty simple (maybe the underlying LinkedHashMap didn't implement contains_key when this code was originally written?)

FlashCat commented 7 years ago

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

rillian commented 7 years ago

Ping on this. We're really like to publish a new sccache release, but it's blocked on being able to use these features of lru-cache. If they're acceptable, could you please merge and publish a new crate release?

Gankra commented 7 years ago

sccache has forked this repo, and we don't seem to have the bandwidth to maintain this anymore. Closing.

rillian commented 7 years ago

@Gankro, If you don't have bandwidth to maintain the crate any more, could you add @luser and I to the crates.io page so we can go forward with our fork as the publicly available crate?

Gankra commented 7 years ago

Details of this decision here: https://users.rust-lang.org/t/all-contain-rs-crates-are-now-in-maintenance-mode/12056

Gankra commented 7 years ago

@rillian I'll strongly consider it, but I'd like to wait a few days to think about the situation and gather responses. I don't know you two super well, so I'm not immediately confident in handing over all the users of this crate to y'all.

rillian commented 7 years ago

np. Thanks for the context!