search

contain-rs / lru-cache

A cache that holds a limited number of key-value pairs
https://contain-rs.github.io/lru-cache/lru_cache/
Apache License 2.0
83 stars 36 forks source link

Add entry API. #47

Open kevincox opened 6 years ago

kevincox commented 6 years ago

This is a clone of the linked_hash_map API. It is also generally implemented by deferring to that implementation. The major change is that VacantEntry.insert() must expire an entry if the cache is full.

FlashCat commented 6 years ago

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.