search

contain-rs / ordered_iter

Ordered iterators
https://contain-rs.github.io/ordered_iter/ordered_iter
Apache License 2.0
13 stars 4 forks source link

OuterJoin can support the trait OrderedMapIterator #11

Closed ghost closed 8 years ago

FlashCat commented 8 years ago

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @reem (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

ghost commented 8 years ago

Anyone?

reem commented 8 years ago

Agh, sorry for dropping this. Looks good, thanks for this.