container-registry / helm-charts-oci-proxy

The Helm Charts OCI Proxy, will proxy and transform Helm Chart into OCI images on the fly. Address any Helm Chart as OCI image.
GNU Affero General Public License v3.0
94 stars 7 forks source link

Remove default annotations from ingress on chart #22

Open EStork09 opened 2 days ago

EStork09 commented 2 days ago

https://github.com/container-registry/helm-charts-oci-proxy/blob/main/chart/values.yaml#L47-L50

annotations:
    kubernetes.io/ingress.class: nginx
    kubernetes.io/tls-acme: "true"
    cert-manager.io/cluster-issuer: letsencrypt-prod

I am using an issuer to create certs and this impacts cert-manager that it cannot have both the cluster-issuer and issuer and cannot remove it as I am running as a sub chart. Could we remove this?

Vad1mo commented 1 day ago

sure