search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Drop `reverse domain name notation` requirement #280

Closed saad-ali closed 5 years ago

saad-ali commented 6 years ago

In a couple of places in the spec we require reverse domain name notation:

message GetPluginInfoResponse {
  // The name MUST follow reverse domain name notation format
  // (https://en.wikipedia.org/wiki/Reverse_domain_name_notation).
  string name = 1;
}

...

// The key prefix MUST follow reverse domain name notation format
// (https://en.wikipedia.org/wiki/Reverse_domain_name_notation).
message Topology {
  map<string, string> segments = 1;
}

We should drop this requirement for 1.0, and let the plugins choose to do forward domain notation, e.g. mycsidriver.mycompany.com for improved readability.

jdef commented 6 years ago

Related to #260

saad-ali commented 6 years ago

Concern: potential for collisions. Counter-argument: low likely hood of collisions

Concern: ease of use. Spec should be as specific as possible. Counter-argument: no one enforces java package naming

Conclusion: Change to be forward only? Gives us consistency. Concern: legacy drivers will have to change. ok pre-1.0

Should address #260 along with this.

saad-ali commented 5 years ago

Closed by https://github.com/container-storage-interface/spec/pull/260