search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

ControllerPublishVolume readonly field not supported? #293

Closed saad-ali closed 5 years ago

saad-ali commented 5 years ago

We should clarify the behavior if a storage system does not support readonly==true on ControllerPublishVolume.

saad-ali commented 5 years ago

We should also clarify what readonly means. Maybe: regardless of the mount (NodePublishVolume) readonly flag, this volume is readonly at the storage layer?

saad-ali commented 5 years ago

CO may not be able to know when to pass in readonly on ControllerPublish.

Hard answer is new capability and extra CO logic to discover when to do this.

Easy answer is plugin should just ignore the field, if it doesn't support it?

Conclusion after discussing with @jdef and @julian-hj let's go with the easy option and clarify it in the spec.

saad-ali commented 5 years ago

Discussed with @julian-hj and @jieyu, we decided that the easy option leaves potential issue if CO uses the same flag for both ControllerPublish and NodePublish readonly fields.

Therefore, we will do the "hard answer".