search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

spec: Clarify target_path and staging_target_path #312

Closed jieyu closed 5 years ago

jieyu commented 5 years ago

This patch clarifies the target_path and staging_target_path in the spec. It is CO's responsibility to make sure that SP has the permission to read or write target_path and staging_target_path, and is able to create files/directories if the path does not exist.

This patch also changes the wording in NodeStageVolume call to enable those plugins that want to use the NodeStageVolume call as a lifecycle hook, but does not want to mount to the staging_target_path.

Closes #285 Closes #80 Closes https://github.com/container-storage-interface/spec/issues/294 Closes https://github.com/container-storage-interface/spec/issues/295

saad-ali commented 5 years ago

Mostly LGTM. Is it worth adding: SP MAY create the target_path as necessary if it does not exist.?

jieyu commented 5 years ago

@saad-ali i don't think that's necessary. The comment already says that The path to which the volume MAY be staged. and The path to which the volume will be published..

saad-ali commented 5 years ago

SGTM LGTM /approve