Is VERSION file necessary?

container-storage-interface / spec

Container Storage Interface (CSI) Specification.

Apache License 2.0

1.34k stars 373 forks source link

Is VERSION file necessary? #324

Open saad-ali opened 5 years ago

saad-ali commented 5 years ago

Follow up from https://github.com/container-storage-interface/spec/pull/321#discussion_r232525730

Do we still need the VERSION file? If not, lets remove it.

saad-ali commented 5 years ago

Not a blocker for 1.0

julian-hj commented 5 years ago

so....if we remove the version file, where do we maintain a record of the current version? I had the notion that folks might consume VERSION in their build scripting, given that protobuf doesn't define it.

If we were to come up with some solution for #170 then I'd agree that this file is unnecessary, but until then, I think if we get rid of it, we'd be forcing everyone to manually define the CSI version they are using, which seems a bid shady to me.

jieyu commented 5 years ago

I think version can be derived from the tag (e.g., v0.3.0, or v1.0.0, etc.) for releases?