spec: Snapshot.created_at should use well-known Timestamp protobuf

container-storage-interface / spec

Container Storage Interface (CSI) Specification.

Apache License 2.0

1.34k stars 373 forks source link

spec: Snapshot.created_at should use well-known Timestamp protobuf #330

Closed jdef closed 5 years ago

jdef commented 5 years ago

https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/timestamp.proto

This would be a breaking change after 1.0, so if this change doesn't land before then maybe we could eventually use a oneof to wrap the existing int-based timestamp and a new field that uses Timestamp.

Ideally we'd resolve this prior to 1.0

saad-ali commented 5 years ago

I support this change.