search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

spec: created_at is a Timestamp. #331

Closed jdef closed 5 years ago

jdef commented 5 years ago

Fixes #330

saad-ali commented 5 years ago

CC @xing-yang @jingxu97 for FYI

jdef commented 5 years ago

I'm happy to make that change later tonight or tomorrow morning... if people want it

On Tue, Nov 13, 2018, 6:47 PM Julian Hjortshoj notifications@github.com wrote:

@julian-hj requested changes on this pull request.

any chance we could rename this field to creation_time or creation_date while we are changing it? The non-nominal field name kind of bugs me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/container-storage-interface/spec/pull/331#pullrequestreview-174642174, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLJhb07EUH4CXatMSv1lxC268uezMks5uu1olgaJpZM4YcvOC .

saad-ali commented 5 years ago

I'm happy to make that change later tonight or tomorrow morning... if people want it

I'm fine with it too. Go for it. I'll wait for it.

xing-yang commented 5 years ago

Thanks @jdef! Yes, Jing and I are fine with the change. Renaming it to creation_time sounds good.

jdef commented 5 years ago

@julian-hj I've renamed the field - PTAL

saad-ali commented 5 years ago

LGTM