search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Fix error code on wrong snapshot ID or topology #412

Closed jsafrane closed 4 years ago

jsafrane commented 4 years ago

Add one more reason to return ALREADY_EXISTS from CreateVolumeRequest: the volume to be created already exists, but it was restored from a different snapshot than requested

This follows all other ALREADY_EXISTS cases - the volume already exists, but it's something else than CO requested.

jieyu commented 4 years ago

This change LGTM. I think we also need to add one more here, which is accessibility_requirements. I.e., the SP should return ALREADY_EXISTS if the CO requested different accessibility_requirements but using the same name. Thoughts?

jsafrane commented 4 years ago

Added accessibility_requirements to the sentence.

xing-yang commented 4 years ago

lgtm