container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

NodeStageVolume is missing readonly field #416

Open saad-ali opened 4 years ago

saad-ali commented 4 years ago

@cduchesne rightfully pointed out that the NodeStageVolumeRequest is missing the bool readonly field which ControllerPublishVolumeRequest and NodePublishVolumeRequest both have. So a driver doesn't know when a global mount should be mounted readonly. Effectivley this is not a huge issue since the final NodePublishVolumeRequest mount does have this information. But ideally we should ensure that even for NodeStageVolumeRequest the right thing happens. Areas to think about: 1) how to add this in a backwards compatible way, 2) if a CO has multiple workloads using the same volume on the same node with a storage system that implements NodeStageVolumeRequest but the first workload requests readonly and the second workload requrests readwrite.

CC @davidz627