@cduchesne rightfully pointed out that the NodeStageVolumeRequest is missing the bool readonly field which ControllerPublishVolumeRequest and NodePublishVolumeRequest both have. So a driver doesn't know when a global mount should be mounted readonly. Effectivley this is not a huge issue since the final NodePublishVolumeRequest mount does have this information. But ideally we should ensure that even for NodeStageVolumeRequest the right thing happens. Areas to think about: 1) how to add this in a backwards compatible way, 2) if a CO has multiple workloads using the same volume on the same node with a storage system that implements NodeStageVolumeRequest but the first workload requests readonly and the second workload requrests readwrite.
@cduchesne rightfully pointed out that the
NodeStageVolumeRequest
is missing thebool readonly
field whichControllerPublishVolumeRequest
andNodePublishVolumeRequest
both have. So a driver doesn't know when a global mount should be mounted readonly. Effectivley this is not a huge issue since the finalNodePublishVolumeRequest
mount does have this information. But ideally we should ensure that even forNodeStageVolumeRequest
the right thing happens. Areas to think about: 1) how to add this in a backwards compatible way, 2) if a CO has multiple workloads using the same volume on the same node with a storage system that implementsNodeStageVolumeRequest
but the first workload requests readonly and the second workload requrests readwrite.CC @davidz627