search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Added Nomad to Container Orchestrators #421 #422

Closed mpron closed 4 years ago

mpron commented 4 years ago

Added a bullet link for Nomad to the readme file linking to the information about CSI support. New feature so it may change as documentation pages are created.

tgross commented 4 years ago

Hi folks, I'm on the Nomad team and was prepping to make a PR myself when I saw this one. We would recommend https://nomadproject.io/docs/internals/plugins/csi/ as a better link.

jieyu commented 4 years ago

@mpron could you update link according to @tgross ?

mpron commented 4 years ago

Done. Sorry I jumped the gun @tgross

tgross commented 4 years ago

Sorry I jumped the gun @tgross

Not at all! Thanks!

shantanugadgil commented 4 years ago

can this be merged now?

mpron commented 4 years ago

@shantanugadgil yes.

shantanugadgil commented 4 years ago

Gak! Celebrated too soon. Will wait for this to be merged!

shantanugadgil commented 4 years ago

@tgross @jieyu @jdef anything holding this back from merging? 😃

saad-ali commented 4 years ago

LGTM

jieyu commented 4 years ago

@mpron could you please sign the CLA https://github.com/container-storage-interface/spec/blob/master/CCLA.pdf and email to container-storage-interface-approvers@googlegroups.com ?

mpron commented 4 years ago

@tgross I leave this to you and your team to run this up the corporate ladder. I'm definitely not the right person to sign that CLA. I'll bow out of this thread now. :)

jieyu commented 4 years ago

@tgross @mpron let me know how you want us to make progress here. Unfortunately, the CLA is a legal boilerplate we'll have to do. I am happy to submit a PR for you guys (I already signed the CLA).

tgross commented 4 years ago

Hi @jieyu, sorry about the delay.

We're still in the process of getting the CLA through our legal team. If you have time to submit the PR for us that'd be great. HashiCorp are going to continue to extend our CSI support in Nomad. So I'm sure we'll have contributions going forward anyways and our internal efforts won't be wasted even if you do so. Thanks!

jieyu commented 4 years ago

@tgross ok, sounds good. We'll wait for you guys to sort out the CLA then.

galeep commented 4 years ago

@jieyu A signed CLA has been sent your way!

jieyu commented 4 years ago

Signed CLA received. Merging.