search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Allow plugin to return OK if NodeUnpublishVolume cannot find a volume #433

Open timoreimann opened 4 years ago

timoreimann commented 4 years ago

In #375, the spec was changed to allow plugins to return OK during ControllerPublishVolume if a volume is not found, thereby solving #373. A similar situation can arise for NodeUnpublishVolume when, say, a previously mounted volume has already been unmounted out-of-band, and the plugin decides that there simply is no more work to do. For such cases, it should not be okay to return OK from NodeUnpublishVolume as well.

I propose we carry over the corresponding amendments done in the context of ControllerPublishVolume to NodeUnpublishVolume. I'd be happy to carry out the spec update if this request finds consent.

This issue was motivated by a discussion that happened on kubernetes-csi/csi-test#258.

/cc @pohly @msau42 @jsafrane @maennchen

timoreimann commented 4 years ago

Would love to hear what folks think of this proposal. Thanks in advance.