search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Secrets in NodeExpandVolume #445

Closed Sh4d1 closed 3 years ago

Sh4d1 commented 4 years ago

Hello!

It would be nice to have secrets available in the NodeExpandVolume.

Usecase : encrypted device with LUKS, which needs the passphrase in order to resize the device on the node.

humblec commented 4 years ago

Indeed , this is a requirement for other use case too. For example, if we need to connect to backend cluster for some validation we need the secret.

One of the use case came up Ceph side is that, at times we need to check the actual size of the image before proceeding on FS resize to avoid false positive returns on fs resize operation. For that we have to connect to the backend cluster which need secret in the request.

Sh4d1 commented 4 years ago

Not sure what the policy is, but I'll gladly open a PR adding secrets to this method 😄

humblec commented 4 years ago

Not sure what the policy is, but I'll gladly open a PR adding secrets to this method smile

Let me invite some key members for their thought from Kube storage side. @saad-ali @jsafrane @msau42 @gnufied @xing-yang can you share your thoughts ?

humblec commented 4 years ago

@gnufied @jsafrane @xing-yang @msau42 @saad-ali this is one of the blocker to support LUKS encryption expansion for CSI drivers. We indeed need secrets/credentials in the NodeExpand request. Can we share your thoughts ?

@Sh4d1 would you like to open a PR for this?

Sh4d1 commented 4 years ago

@humblec yep :smile:

humblec commented 4 years ago

@humblec yep smile

Thanks @Sh4d1 ! Let me pull others to the PR :+1: