search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Build is broken with go 1.16 #471

Open gnufied opened 3 years ago

gnufied commented 3 years ago

We don't have to fix this right away but it looks like builds might be broken in 1.16 because of go module changes.

(cd /home/hekumar/goal/src/github.com/golang/protobuf/ && go get -v -d $(go list -f '{{ .ImportPath }}' ./...)) && \ go build -o "protoc-gen-go" github.com/golang/protobuf/protoc-gen-go no required module provides package github.com/golang/protobuf/protoc-gen-go: working directory is not part of a module make[1]: [Makefile:66: protoc-gen-go] Error 1 make[1]: Leaving directory '/home/hekumar/goal/src/github.com/container-storage-interface/spec/lib/go' make: [Makefile:36: build] Error 2

gnufied commented 3 years ago

it works by explicitly disabling go modules though:

GO111MODULE=off make
jdef commented 3 years ago

Thanks for reporting this

On Tue, Mar 2, 2021, 10:36 PM Hemant Kumar notifications@github.com wrote:

it works by explicitly disabling go modules though:

GO111MODULE=off make

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/container-storage-interface/spec/issues/471#issuecomment-789402404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR5KLAHUSXECQJBVTOIJZTTBWVCRANCNFSM4YQKWBTQ .