search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Add volume_context to ControllerExpandVolumeRequest #478

Closed ArbelNathan closed 3 years ago

ArbelNathan commented 3 years ago

please consider adding volume_context to ControllerExpandVolumeRequest, it will help us with Topology support. right now we don't know the storage system of the volume in the ControllerExpandVolume call because our secret contains JSON with all the supported storage systems, only volume_context or topologies can tell us where the volume is stored.

jdef commented 3 years ago

This sounds completely reasonable. Mind submitting a PR?

On Mon, May 3, 2021, 4:59 AM Arbel Nathan @.***> wrote:

please consider adding volume_context to ControllerExpandVolumeRequest, it will help us with Topology support. right now we don't know the storage system of the volume in the ControllerExpandVolume call because our secret contains JSON with all the supported storage systems, only volume_context or topologies can tell us where the volume is stored.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/container-storage-interface/spec/issues/478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR5KLGKYL4ZXP56DHHLQ6DTLZQYXANCNFSM44AODMMA .

ArbelNathan commented 3 years ago

sure, if we are on it, could we add volume_context to ControllerUnpublishVolumeRequest?

jdef commented 3 years ago

No. Unpublish needs to be able to execute in the case that the CO forgets context.

On Mon, May 3, 2021, 8:43 AM Arbel Nathan @.***> wrote:

sure, if we are on it, could we add volume_context to ControllerUnpublishVolumeRequest?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/container-storage-interface/spec/issues/478#issuecomment-831234687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR5KLDTBPPI3X6DQSGHTLDTL2LATANCNFSM44AODMMA .

ArbelNathan commented 3 years ago

ok, tnx