humblec
commented
2 years ago may be its good to give some references in the PR description to its usage in kube or csi drivers as we are promoting this field.
Closed pohly closed 2 years ago
humblec
commented
2 years ago may be its good to give some references in the PR description to its usage in kube or csi drivers as we are promoting this field.
pohly
commented
2 years ago I've added some links.
xing-yang
commented
2 years ago /lgtm
xing-yang
commented
2 years ago /assign @saad-ali
humblec
commented
2 years ago lgtm..
jdef
commented
2 years ago RIP travis.org
Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.
Please regenerate the Go bindings since you're changing a protobuf descriptor.
pohly
commented
2 years ago It looks like updating lib/go/csi/csi.pb.go was also skipped in d64255d7. Some of the changes that I got are from that commit.
The reason I missed the lib/go/csi update is that I expected the top-level "make" to update everything. Would it make sense to add that?
jdef
commented
2 years ago The reason I missed the lib/go/csi update is that I expected the top-level "make" to update everything. Would it make sense to add that?
probably, maybe in a follow-up PR?
pohly
commented
2 years ago Can this be merged and included in a new release?
pohly
commented
2 years ago The fix for the Makefile is in https://github.com/container-storage-interface/spec/pull/500. I did not include the updated lib/go/csi/csi.pb.go there because that's already pending here, but it might be cleaner to merge that change via the other PR.
xing-yang
commented
2 years ago CC @saad-ali
saad-ali
commented
2 years ago /lgtm /approve
saad-ali
commented
2 years ago RIP travis.org
Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.
Opened https://github.com/container-storage-interface/spec/issues/501
Kubernetes and several CSI drivers (for example, PMEM-CSI) have been using that field for a while now and no changes to the semantic are expected, therefore the alpha status can and should be removed.
The minimum_volume_size field is not used by Kubernetes. The semantic is probably stable, but further practical experience with it might be desirable before promoting it.