search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Move volume mount group feature GA #509

Closed gnufied closed 2 years ago

gnufied commented 2 years ago

Drop alpha from volume_mount_group feature.

jdef commented 2 years ago

is this the first time we've promoted something from alpha to GA? i'm wondering if there's a compatibility impact w/ respect to completely dropping the alpha annotations vs. setting them to false. maybe i'm overthinking this. has anyone tested interactions between older bindings (w/ alpha set) against newer bindings (w/o alpha)?

gnufied commented 2 years ago

This is another instance https://github.com/container-storage-interface/spec/pull/499 when we moved things over from alpha to GA. I will look into compatibility aspects of when we move a feature from alpha to GA.

gnufied commented 2 years ago

@jdef So I ran e2e of k8s by updating kubernetes with my version of CSI driver and let driver run a released version of CSI with alpha APIs. And all e2es are still passing:

  should pass FSGroup to CSI driver if it is set in pod and driver supports VOLUME_MOUNT_GROUP                                                                                                                                                               
    should not pass FSGroup to CSI driver if it is set in pod and driver does not supports VOLUME_MOUNT_GROUP

Is that enough as signal that dropping alpha annotation does not break anything?

jingxu97 commented 2 years ago

/cc @saad-ali