search

container-storage-interface / spec

Container Storage Interface (CSI) Specification.
Apache License 2.0
1.34k stars 373 forks source link

Regenerate with protoc-gen-go 1.3.5 #572

Open jsafrane opened 1 month ago

jsafrane commented 1 month ago

Regenerated csi.pb.go with older protoc-gen-go to restore grpc message structures.

go.mod has github.com/golang/protobuf 1.5.3, which has a protoc-gen-go that generates code that introduces breaking changes, see #570.

Instead of 1.5.3, download github.com/golang/protobuf v1.3.2 separately, build protoc-gen-go from it and use it to generate csi.pb.go. The code is copied from the previous release of CSI spec, only with minor changes.

A future update to 1.5.3 must be done carefully and announce a breaking change.

Which issue(s) this PR fixes:

Fixes #570

Does this PR introduce an API-breaking change?:

Restored generated protobuf go message structures compatible with CSI spec v1.9.0.
huww98 commented 1 month ago

Also note this PR does not revert the breaking change of requiring embedding UnimplementedIdentityServer.