search

containerbuildsystem / atomic-reactor

Simple python library for building docker images.
BSD 3-Clause "New" or "Revised" License
135 stars 61 forks source link

exit_sendmail plugin always fails to find koji build ID for scratch builds #1591

Open ktdreyer opened 3 years ago

ktdreyer commented 3 years ago

scratch builds always hit this code path in atomic_reactor/plugins/exit_sendmail.py:

self.koji_build_id = self.workflow.exit_results.get(KojiImportPlugin.key)
if not self.koji_build_id:
    self.log.info("Failed to fetch koji build ID")

If it's a scratch build, we do not need to try to look up a Koji build ID.

ktdreyer commented 2 years ago

What if we just deleted this plugin entirely: https://github.com/containerbuildsystem/atomic-reactor/issues/1710