containerbuildsystem / atomic-reactor

Simple python library for building docker images.
BSD 3-Clause "New" or "Revised" License
135 stars 61 forks source link

cachi2: generate remote-source.json #2113

Closed MartinBasti closed 2 months ago

MartinBasti commented 2 months ago

Cachi2 doesn't provide remote-source.json but for backward compatibility OSBS must provide it.

STONEBLD-2585

Maintainers will complete the following section

mkosiarc commented 2 months ago

LGTM, in ideal world we could use more abstraction by exporting some functionality to individual helper functions so they could be read and understood better (for example, the type matching or version finding). But I am not expecting any change here.

mkosiarc commented 2 months ago

I appreciate the comments, without them I would be completely lost.