containerbuildsystem / cachi2

GNU General Public License v3.0
7 stars 25 forks source link

feat(pkg-mgr:pip): add 'pip_package_binary' property... #508

Closed ben-alkov closed 4 months ago

ben-alkov commented 5 months ago

...to PropertySet and sbom::PropertyName so it can be processed

Signed-off-by: Ben Alkov ben.alkov@redhat.com# Maintainers will complete the following section

Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:

ben-alkov commented 5 months ago

I need to add a couple of unit tests (probably just a couple of scenarios for existing tests) to cover new lines in 'pip.py' and 'property_semantics.py'.

ben-alkov commented 4 months ago

Ready for review. Still needs unit tests to increase coverage, but I believe the implementation is complete and correct.

ben-alkov commented 4 months ago

Unit tests are done, new line coverage is %100 :tada:.